You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
ci: skip the milestone check in forks instead of failing it - #8053
"Check PR milestone / Require a milestone" also runs in forks of this repo, where it fails on every non-draft pull request (for example stacked PRs opened against a contributor's own fork). Milestones only mean something on dashpay/dash, so in a fork the check is a red X that nobody can or should clear.
What was done?
Gate the job on github.repository == 'dashpay/dash', the same guard predict-conflicts.yml and the Guix release job already use. In forks the job is now skipped rather than failed; on dashpay/dash nothing changes.
How Has This Been Tested?
Parsed the workflow and checked the job condition. The check runs on pull_request_target, which uses the base branch's workflow, so the new condition takes effect on PRs only after this merges.
Breaking Changes
None.
Checklist:
I have performed a self-review of my own code
I have made corresponding changes to the documentation
I have assigned this pull request to a milestone (if you have permission to set one)
Milestones only mean something on dashpay/dash. In forks, pull requests
(for example stacked PRs opened against a contributor's own fork) failed
"Require a milestone" even though there is nothing to set. Gate the job on
the repository so it is skipped there instead.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
No actionable comments were generated in the recent review.
Walkthrough
The milestone workflow job now runs only when the repository is dashpay/dash and the pull request is not a draft. Previously, the job condition checked only whether the pull request was not a draft.
dashpay/dash#7987: Added the milestone workflow whose job condition this change narrows.
dashpay/dash#8008: Set the pull_request_target trigger used by the workflow with this job condition.
Merge Risk: Minimal · up to eac03
The change skips milestone checks in fork repositories while preserving checks for non-draft pull requests targeting dashpay/dash. It is ready to merge after normal checks.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title names the main change: the milestone check job is now skipped in forks instead of failing. The raw summary confirms the workflow gate on dashpay/dash and non-draft PRs, so the title matches …
Description check
The description states the problem (the milestone check fails in forks on non-draft PRs) and the fix (gating the job on github.repository == 'dashpay/dash'). It also covers testing and the timing of t…
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the main change: the milestone check job is now skipped in forks instead of failing. The raw summary confirms the workflow gate on dashpay/dash and non-draft PRs, so the title matches the changeset. The title uses the conventional 'ci:' prefix and stays under 60 characters.
Full details: Description check
Explanation
The description states the problem (the milestone check fails in forks on non-draft PRs) and the fix (gating the job on github.repository == 'dashpay/dash'). It also covers testing and the timing of the change under pull_request_target. This directly describes the changed workflow, so the description is related to the changeset.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Repository UI
Review profile: CHILL
Plan: Advanced
Run ID: 4830ac63-ab96-4dc9-9ae0-72e42b56590d
Commits
Reviewing files that changed from the base of the PR and between 9e5e3d5 and eac03d5.
Files selected for processing: 1
.github/workflows/check-milestone.yml
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
"Check PR milestone / Require a milestone" also runs in forks of this repo, where it fails on every non-draft pull request (for example stacked PRs opened against a contributor's own fork). Milestones only mean something on dashpay/dash, so in a fork the check is a red X that nobody can or should clear.
What was done?
Gate the job on
github.repository == 'dashpay/dash', the same guardpredict-conflicts.ymland the Guix release job already use. In forks the job is now skipped rather than failed; on dashpay/dash nothing changes.How Has This Been Tested?
Parsed the workflow and checked the job condition. The check runs on
pull_request_target, which uses the base branch's workflow, so the new condition takes effect on PRs only after this merges.Breaking Changes
None.
Checklist:
🤖 Generated with Claude Code